outdated manifests don't allow creation of DaemonSet

fluent / fluent-bit-kubernetes-logging

Fluent Bit Kubernetes Daemonset

Apache License 2.0

468 stars 248 forks source link

outdated manifests don't allow creation of DaemonSet #59

Open sanyer opened 4 years ago

sanyer commented 4 years ago

According to kubectl changelog for 1.15.0:

The following APIs are no longer served by default:

All resources under apps/v1beta1 and apps/v1beta2 - use apps/v1 instead
daemonsets, deployments, replicasets resources under extensions/v1beta1 - use apps/v1 instead
networkpolicies resources under extensions/v1beta1 - use networking.k8s.io/v1 instead
podsecuritypolicies resources under extensions/v1beta1 - use policy/v1beta1 instead

andbuitra commented 4 years ago

Indeed. This issue is affecting Kubernetes 1.16+. I will try to work on a pull request for this; it shouldn't be that hard.

[EDIT] Now that I checked on the docs site it does say that the apiVersion has to be manually changed from the manifest (https://docs.fluentbit.io/manual/installation/kubernetes#note-for-kubernetes-v-1-16). However this is not enough as "spec" expects a "selector" property and the manifest will be rejected without it. Sadly this is not reflected on the repo's README. Maybe @edsiper could take a look?

andbuitra commented 4 years ago

I double checked and this in fact is fixed on PR https://github.com/fluent/fluent-bit-kubernetes-logging/pull/66

gabegorelick commented 3 years ago

I think https://github.com/fluent/fluent-bit-kubernetes-logging/pull/81 fixed most or all of these.