search

fluent / fluent-bit

Fast and Lightweight Logs and Metrics processor for Linux, BSD, OSX and Windows
https://fluentbit.io
Apache License 2.0
5.73k stars 1.56k forks source link

Update msgpack-c library #9246

Open Athishpranav2003 opened 3 weeks ago

Athishpranav2003 commented 3 weeks ago

With the new release in msgpack library it would be great if it's updated here too(will be needed to clean some code in parser filter)

Athishpranav2003 commented 3 weeks ago

@edsiper I have created the issue

edsiper commented 3 weeks ago

@Athishpranav2003 thanks for opening this issue.

is there any specific reason to upgrade the library version ?

Athishpranav2003 commented 3 weeks ago

While trying to work on feature request in #8893 I thought methods to construct the struct would make the code neat. It was added to the lib recently after I worked with the maintainer of msgpack

edsiper commented 3 weeks ago

Looking at https://github.com/fluent/fluent-bit/issues/8893 it seems to me that the straightforward way to accomplish is just defining an extra config option to do the packing instead of modifying the underlaying msgpack library.

Athishpranav2003 commented 3 weeks ago

I have a sol without updating msgpack But updating leads to clean code. Which one do u want me to proceed with

Athishpranav2003 commented 3 weeks ago

So basically some redundant code can be avoided with the updated msgpack lib. @edsiper idk if its worth the effort to update the lib. If not please let me know. I will go ahead and work with existing lib

edsiper commented 3 weeks ago

I am ok with updating msgpack if there is some bug or security problem found, if is not the case I will put it on hold.

For data manipulation, we are moving forward to use the apis provided by fluent/cfl, specifically cfl_object to reduce the number of direct serialization calls with msgpack-c. We are providing high-level primitives to simplify the work done in plugins/processors in general.