search

fluent / fluent-logger-node

A structured logger for Fluentd (Node.js)
Apache License 2.0
259 stars 83 forks source link

TS: Winston dependency even if not using Winston transport #143

Closed Kageetai closed 5 years ago

Kageetai commented 5 years ago

I am using typescript for my project but don't use any winston transport whatsoever, but I am still required to install winston in my own projects dependencies, because otherwise build fails because of this line: https://github.com/fluent/fluent-logger-node/blob/master/lib/index.d.ts#L8

okkez commented 5 years ago

Hmm, winston-transport is an optional library in this fluent-logger-node. I'm not familiar with TypeScript definitions (index.d.ts).

Can I remove type definitions related to winston-transport?

Kageetai commented 5 years ago

I am also not too familiar with the type definitions files, but is it auto-generated? If not just remove it probably. Or add winston-transport to the dependencies, so it will also be installed, when installingfluent-logger-node`. But I think removing any notion to winston is better.

VladaPetrovic commented 4 years ago

Great for merging this fix into master. When can we expect new npm release ?