search

fluent / fluent-logger-python

A structured logger for Fluentd (Python)
http://fluentd.org/
Other
444 stars 138 forks source link

Relax top end of Python version range specifier? #161

Closed seansfkelley closed 4 years ago

seansfkelley commented 4 years ago

Would it be possible to relax the Python version specifier

https://github.com/fluent/fluent-logger-python/blob/e00bcdd8ee2bd36e470460770cb7ab8b91fa3f87/setup.py#L40

to not put a cap on the highest supported version? This is singlehandedly requiring all of the repos in my product to specify the same < rules as fluent-logger-python even though we control our Python version and generally support the latest release.

Does fluent-logger-python do anything sufficiently weird that you would expect it to break on minor language versions? https://github.com/fluent/fluent-logger-python/issues/148 suggests "not really", and I would prefer to not block our language upgrades on fluent-logger-python when the duck types are likely to just work!

arcivanov commented 4 years ago

The version pin tries to indicate that there is no data on it being tested or even minimally functioning. But I suppose you're right, caveat emptor and all that. I'll relax the restriction.

seansfkelley commented 4 years ago

Yeah, I figured that was the reason, but I'm all for caveat emptor when it comes to Python.

Glad to hear it, and thanks for the quick response!