Closed nileshpatra closed 3 years ago
@arcivanov Do you have any concern for this patch?
Yes, I do @repeatedly. Specifically due to #157. We have two camps, #157 and #171, arguing that BOTH pre-1.0 and post-1.0 msgpack work. Both can't be true. The test harness used in FLP 0.9.6 does not actually test against FluentD so I can only rely on bug reports.
The Fluent Logger 1.0 has a harness rewrite that would allow compatibility testing with whatever versions of fluentd/-bit but I simply don't have time to work on it right now.
We are starting to get unresolvable venvs because of the upper-pin. Is there anything we can do to help here?
I'll remove the pin today in that case.
Since the
encoding
option is always UTF-8 with msgpack>=1, I've remove the same.Otherwise it fails with:
After the change, it goes green: