fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
587 stars 250 forks source link

fix parsersfile default parsers.conf path #1225

Closed cw-Guo closed 4 months ago

cw-Guo commented 4 months ago

What this PR does / why we need it:

Fixed a bug, which would invalidate the default fluent-bit parsers conf

Which issue(s) this PR fixes:

Fixes #1219

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

benjaminhuo commented 4 months ago

Thanks! @cw-Guo cc @onecer @wanjunlei

elsnepal commented 4 months ago

Thanks! @cw-Guo cc @onecer @wanjunlei

why those two parsers.conf & parsers_multiline.conf in different location? This will fix default parser not being deployed but will this not break custom parser from loading?

cw-Guo commented 4 months ago

@elsnepal It won't affect the non-default parsers.

see here

COPY conf/fluent-bit.conf conf/fluent-bit.yaml conf/parsers.conf /fluent-bit/etc/

When we build the fluent-bit image, we copy conf/parsers.conf to /fluent-bit/etc/parsers.conf

in conf/parsers.conf, we include the non-default parsers. @INCLUDE /fluent-bit/config/parsers.conf

see https://github.com/fluent/fluent-operator/blob/master/conf/parsers.conf#L1