search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
587 stars 250 forks source link

fix: rewrite tag nil pointer reference #1232

Closed cw-Guo closed 4 months ago

cw-Guo commented 4 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1231

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

benjaminhuo commented 4 months ago

@cw-Guo Thanks for fixing this. The controller-gen has been upgraded in https://github.com/fluent/fluent-operator/pull/1220/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R151

You may need to update the version in your env and build again

cw-Guo commented 4 months ago

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151

@benjaminhuo What do i need to do specifically to upgrade my env?

benjaminhuo commented 4 months ago

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151

@benjaminhuo What do i need to do specifically to upgrade my env?

@cw-Guo You may need to make manifests generate

cw-Guo commented 4 months ago

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151 @benjaminhuo What do i need to do specifically to upgrade my env?

@cw-Guo You may need to make manifests generate

@benjaminhuo Yes, I have already do that. But It looks like the go.mod keeps fetching k8s.io/code-generator v0.26.1

cw-Guo commented 4 months ago

@benjaminhuo looks like my go version was 1.21. Fixed now.