search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
578 stars 246 forks source link

parameterized the tagging of tail plugin #1237

Open harshvora10101 opened 2 months ago

harshvora10101 commented 2 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes 1 : Parameterising the tag for tail plugin. Overriding this value will help changing the tags according to the requirements.

benjaminhuo commented 2 months ago

@harshvora10101 Thanks for the PR. You'll need to sign your commit by:

git commit -s --amend
git push -f
harshvora10101 commented 2 months ago

@benjaminhuo Added the required changes.

benjaminhuo commented 2 months ago

There are output plugins affected too https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-opensearch.yaml#L12

Fluent Operator is used to deploy FluentBit to collect k8s logs, so kube.* is ok. I wonder what's the reason for changing this tag to others.

cc @wanjunlei

harshvora10101 commented 2 months ago

@benjaminhuo

With this change, we are not changing the tag (Just making the code generalized). So I doubt that output plugins will be affected.

There are use cases where we need multiple tail plugins for different applications with different tags. So a hardcoded tag is hard to change.

harshvora10101 commented 2 months ago

To be precise There are multiple tail plugins used for kubernetes with xyz.kube.* and abc.kube.* etc.

wenchajun commented 1 month ago

https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-elasticsearch.yaml#L12 Shouldn't this situation be dealt with as well?