Closed jiuxia211 closed 2 months ago
Thanks for the PR. You'll need to sign your commit by:
git commit -s --amend
git push -f
I see
./hack/update-codegen.sh
>> Temporary output directory /tmp/tmp.9aV294mKFK
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.
I see
./hack/update-codegen.sh >> Temporary output directory /tmp/tmp.9aV294mKFK ERROR: generate-groups.sh has been removed. ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.
I updated update-codegen.sh following https://github.com/weaveworks/flagger/tree/main/hack but it doesn't seem to produce any output or changes and I'm not quite sure why this is happening
Great, thanks @jiuxia211 ! Looks like only one problem remains:
cc @wanjunlei
I see
./hack/update-codegen.sh >> Temporary output directory /tmp/tmp.9aV294mKFK ERROR: generate-groups.sh has been removed. ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.
I updated update-codegen.sh following https://github.com/weaveworks/flagger/tree/main/hack but it doesn't seem to produce any output or changes and I'm not quite sure why this is happening
You can run the command in your machine
make verify-codegen
>> Temporary output directory /tmp/tmp.oapWI9rc0l
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.
>> Removing /tmp/tmp.oapWI9rc0l
make: ***Makefile:91: verify-codegen] Error 1
https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fd-image.yaml#L179 this shoud be updated too.
This is great, thank you @jiuxia211 !
@jiuxia211 is it possible for you to upgrade these new dependencies?
Thanks
@jiuxia211 is it possible for you to upgrade these new dependencies?
Thanks
OK, assign it to me
…sigs.k8s.io/controller-runtime,github.com/onsi/gomega
What this PR does / why we need it:
This PR updates multiple dependencies to their latest versions to ensure compatibility and benefit from the latest features and bug fixes. Specifically, it bumps the following dependencies:
k8s.io/client-go
from0.26.3
to0.30.2
k8s.io/apimachinery
from0.27.4
to0.30.2
k8s.io/api
from0.26.3
to0.30.2
sigs.k8s.io/controller-runtime
from0.14.6
to0.18.4
github.com/onsi/gomega from
1.30.0
to1.33.1
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
None
Additional documentation, usage docs, etc.: