fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
578 stars 246 forks source link

build(deps): bump k8s.io/client-go, k8s.io/apimachinery, k8s.io/api, … #1251

Closed jiuxia211 closed 2 months ago

jiuxia211 commented 2 months ago

…sigs.k8s.io/controller-runtime,github.com/onsi/gomega

What this PR does / why we need it:

This PR updates multiple dependencies to their latest versions to ensure compatibility and benefit from the latest features and bug fixes. Specifically, it bumps the following dependencies:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

wenchajun commented 2 months ago

Thanks for the PR. You'll need to sign your commit by:

git commit -s --amend
git push -f
wenchajun commented 2 months ago

I see

./hack/update-codegen.sh
>> Temporary output directory /tmp/tmp.9aV294mKFK
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.
jiuxia211 commented 2 months ago

I see

./hack/update-codegen.sh
>> Temporary output directory /tmp/tmp.9aV294mKFK
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.

I updated update-codegen.sh following https://github.com/weaveworks/flagger/tree/main/hack but it doesn't seem to produce any output or changes and I'm not quite sure why this is happening

benjaminhuo commented 2 months ago

Great, thanks @jiuxia211 ! Looks like only one problem remains: image

cc @wanjunlei

wenchajun commented 2 months ago

I see

./hack/update-codegen.sh
>> Temporary output directory /tmp/tmp.9aV294mKFK
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.

I updated update-codegen.sh following https://github.com/weaveworks/flagger/tree/main/hack but it doesn't seem to produce any output or changes and I'm not quite sure why this is happening

You can run the command in your machine

make verify-codegen
>> Temporary output directory /tmp/tmp.oapWI9rc0l
ERROR: generate-groups.sh has been removed.
ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.

>> Removing /tmp/tmp.oapWI9rc0l
make: ***Makefile:91: verify-codegen] Error 1
wenchajun commented 2 months ago

https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fd-image.yaml#L179 this shoud be updated too.

benjaminhuo commented 2 months ago

This is great, thank you @jiuxia211 !

benjaminhuo commented 1 month ago

@jiuxia211 is it possible for you to upgrade these new dependencies?

Thanks

image

jiuxia211 commented 1 month ago

@jiuxia211 is it possible for you to upgrade these new dependencies?

Thanks

image

OK, assign it to me