search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
587 stars 250 forks source link

Set explicit fluent-bit name label selector #1293

Closed rmvangun closed 3 months ago

rmvangun commented 3 months ago

What this PR does / why we need it:

The fluent-bit service is created with a hardcoded label, https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-fluentBit.yaml#L9

This seems reasonable? So I added this to the ServiceMonitor selector as well, and removed the use of the fluent-operator labels.

Which issue(s) this PR fixes:

Fixes #1292

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

benjaminhuo commented 3 months ago

@rmvangun you'll need to sign your commit

git commit -s --amend git push -f

cc @wenchajun @wanjunlei