search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
587 stars 250 forks source link

BUG: re-add accidently removed flag.Parse #1294

Closed developer-guy closed 3 months ago

developer-guy commented 3 months ago

What this PR does / why we need it:

In the commit at https://github.com/fluent/fluent-operator/commit/d8e206004898e6e86f1bcbfeaf192916f9fb6293 I saw that someone accidentally removed the flag.Parse line, which caused fluent-watcher to ignore any CLI flag values, so I added it back

Which issue(s) this PR fixes:

Fixes re

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

developer-guy commented 3 months ago

kindly ping @benjaminhuo

developer-guy commented 3 months ago

Thanks @benjaminhuo, one question though, will you cut a new release with that fix included?

developer-guy commented 3 months ago

kindly ping @benjaminhuo

cw-Guo commented 3 months ago

@developer-guy A new version is scheduled, see this issue. thanks for the good catch again!