search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
587 stars 250 forks source link

Changed the kafka_types.go file and introduced a mapvalue struct. #1328

Open TheJadeLion2004 opened 2 months ago

TheJadeLion2004 commented 2 months ago

In kvs.go, introduced an InsertValueMap function and a SecretProvider interface.

What this PR does / why we need it:

The PR attempts to change the type of the Kafka struct from a dictionary of strings to a dictionary of variant type, where the variant contains either a string or a *plugins.Secret. Needed to also change the InsertStringValueMap function and replace it by an insert MapValueMap function which does whatever the original function does, but now, tries to add elements to the map of the variant type.

An interface was used to avoid circular dependency, however there is some deepcopy error that is being generated.

Which issue(s) this PR fixes:

Fixes # https://github.com/fluent/fluent-operator/issues/1152

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

TheJadeLion2004 commented 2 months ago

I've created a pull request in order to check the base logic, and to get help in verifying errors. This is NOT a working PR.