msi: migrate td-agent*.bat

[kenhys]

msi: migrate td-agent*.bat

Before:

c:\opt\td-agent\bin\td-agent.bat c:\opt\td-agent\bin\td-agent-gem.bat

After:

c:\opt\td-agent\fluentd.bat c:\opt\td-agent\fluent-gem.bat

If td-agent-gem.bat was renamed to fluent-gem.bat, it conflict with c:\opt\td-agent\fluent-gem.bat which fluentd gem provides. Not to cause such a situation, put them under c:\opt\td-agent.

To keep compatibility, td-agent.bat and td-agent-gem are provided as hardlink.

[kenhys]

failure:: assets/fluentd.bat is overriden.

[ashie]

So in this PR, changed to provide unique batch file - fluent.bat.

fluent means too wide nowaday. Although it's origianl name of fluentd, it means our organization name for now. So that it might be ambiguous for users what the fluent.bat does.

How about placing fluentd.bat and fluent-gem.bat just under /opt/td-agent(fluent), and add there to $PATH. I think it has some merits.

• Placing execution files just under the application folder is quite usual on Windows.
• Although they have same name with the one under /opt/td-agent/bin, users can easily recognize that the files just under /opt/td-agent/ have higher priority.
• They won't overwritten by gem.

Or leaving td-agent.bat and td-agent-gem.bat as is and put symlinks with fluent prefix just under /opt/td-aget(fluent) might be better.

[daipom]

@ashie I see. I agree.

@kenhys About the link files:

$ td-agent.lnk --version
td-agent 5.0.0 fluentd 1.16.1 (0a6d706a9cee5882d751b2cc6169696709df0134)

$ td-agent --version
'td-agent' は、内部コマンドまたは外部コマンド、
操作可能なプログラムまたはバッチ ファイルとして認識されていません。

[daipom]

It seems that we can omit .bat but we can't omit .lnk. I don't know this Windows specification well though,,,

[ashie]

NOTE: There is no need to provide td-agent-gem.bat as asset because it is almost same as fluent-gem.bat which is installed by fluentd gem.

It might be better to modify to set GEM_HOME and GEM_PATH like the one on GNU/Linux. Setting them can suppress referring other directories unexpectedly configured by users.

[kenhys]

$ td-agent --version 'td-agent' は、内部コマンドまたは外部コマンド、 操作可能なプログラムまたはバッチ ファイルとして認識されていません。

Thank you for verifying it.

It seems that hardlink is better solution...

[kenhys]

How about placing fluentd.bat and fluent-gem.bat just under /opt/td-agent(fluent), and add there to $PATH. I think it has some merits.

Putting these files under /opt/td-agent is a good approach. I'll follow it.

[kenhys]

Even though without custom action, rollback occurs. checking...

[kenhys]

Even though without custom action, rollback occurs. checking...

withoutca.log

Terminated after property change:

MSI (c) (88:1C) [14:50:00:813]: PROPERTY CHANGE: Adding dir8D9828541E9745DA0C06D1FC23D6C150 property. Its value is 'c:\opt\

It seems that InstallInitialize is not called...

[kenhys]

Succeed to install again.

[kenhys]

Old bat is provided as hardlink.

[kenhys]

checking with/without ComponentGuidGenerationSeed behavior.

[kenhys]

dead hardlink issue was fixed.

[kenhys]

TODO: fix mismatched path issue

[kenhys]

TODO: fix mismatched path issue

Fixed it.

[ashie]

I'm still checking...

[ashie]

Thanks!