msi: migration to c:\opt\fluent

[kenhys]

msi: migrate to c:\opt\fluent

Before:

• Configuration c:\opt\td-agent\etc\td-agent\td-agent.conf
• Log files: c:\opt\td-agent

After:

• Move configuration to c:\opt\fluent\etc\fluent\td-agent.conf
• Create symbolic link to c:\opt\fluent\etc\fluent from c:\opt\td-agent\etc\td-agent.
• Overwrite c:\opt\fluent\etc\fluentd.conf with td-agent.conf (when upgrade)
• Migrate to FLUENT_PACKAGE_TOPDIR environment variable.
• Keep old logs as is:

[kenhys]

debug-msi.log

InstallExecuteSequence doesn't work as expected :thinking:

[kenhys]

newly install works as expected, not for upgrade. pr494-new-install.log pr494-upgrade.log

[kenhys]

Unexpectedly action was skipped this action should not executed during upgrade.

MSI (s) (50:1C) [16:52:42:112]: Note: 1: 2265 2:  3: -2147287035 
MSI (s) (50:1C) [16:52:42:112]: Server not locked: locking for product {4FEF158E-E67C-4D05-B7E2-55DA1B33AF9F}
Action ended 16:52:42: InstallInitialize. Return value 1.
MSI (s) (50:1C) [16:52:42:125]: Skipping action: SetDeleteCompatTdAgentBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: DeleteCompatTdAgentBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: SetDeleteCompatTdAgentGemBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: DeleteCompatTdAgentGemBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Doing action: ProcessComponents
MSI (s) (50:1C) [16:52:42:125]: Note: 1: 2205 2:  3: ActionText 
Action 16:52:42: ProcessComponents. Updating component registration
Action start 16:52:42: ProcessComponents.

[kenhys]

PostInstall action is called.

MSI (s) (50:1C) [16:53:06:342]: Executing op: ActionStart(Name=PostInstall,,)
Action 16:53:06: PostInstall. 
MSI (s) (50:1C) [16:53:06:344]: Executing op: CustomActionSchedule(Action=PostInstall,ActionType=3073,Source=BinaryData,Target=WixQuietExec64,CustomActionData="c:\opt\fluent\bin\fluent-package-post-install.bat")
MSI (s) (50:B4) [16:53:06:352]: Invoking remote custom action. DLL: C:\WINDOWS\Installer\MSICEAC.tmp, Entrypoint: WixQuietExec64
WixQuietExec64:  Restoring gems to pristine condition...
WixQuietExec64:  Skipped error_highlight-0.5.1, it is a default gem

[kenhys]

postinstall's if exist "%~dp0..\..\td-agent" ( condition may not be evaluated expectedly :thinking:

[kenhys]

check error log: upgrade.take1.rollback.zip

[kenhys]

check error log: upgrade.take1.rollback.zip

Should align not expected WixQuietExec64 execution order.

[kenhys]

upgrade-echo-on.u8.log tracked via @echo on, but it seems that the second if exist ... sequence is not executed.

[kenhys]

It is out of scope, I've found that post-install was always called because of a mismatch...

WixQuietExec64:  C:\Windows\SysWOW64>if not "c:\opt\fluent\bin\" == "C:\opt\fluent\bin\" ("c:\opt\fluent\bin\gem" pristine --only-executables --all ) 
WixQuietExec64:  Restoring gems to pristine condition...

[kenhys]

When executing extracted bat file content to simplified msi, it will be kicked. (even though weird mojibake errror)

[kenhys]

with 7fb0059, WixQuietExec64 failure was fixed, but it works still unexpectdly, checking why...

[kenhys]

c:\opt\td-agent was linked to c:\opt\fluent.

[kenhys]

c:\opt\fluent\var\log\td-agent was linked to c:\opt\fluent\var\log\fluent.

[daipom]

Thanks for this fix! I will review this early next week.

[kenhys]

also updated commit log.

[daipom]

If the old td-agent service is running, this pop-up appears. (Maybe it's been that way before. I'll check it.)

[daipom]

If the old td-agent service is running, this pop-up appears. (Maybe it's been that way before. I'll check it.)

I confirmed it's been that way before. (This message appears though we don't need a reboot) We don't need to care about this in this PR.

[kenhys]

Try to reduce a risk of losing files.

[kenhys]

changing path separator issue may be solved with "v=!v:\=/!" expression.

[kenhys]

Need to fix:

WixQuietExec64:  ボリューム シリアル番号は 7830-FC66 です
WixQuietExec64:  C:\OPT\TD-AGENT
WixQuietExec64:  └─etc
WixQuietExec64:      └─td-agent
WixQuietExec64:  "Create symlink c:\opt\fluent\var\log\td-agent to c:\opt\fluent\var\log\fluent"
WixQuietExec64:  指定されたパスが見つかりません。
WixQuietExec64:  "Create symlink c:\opt\td-agent\etc\td-agent to c:\opt\fluent\etc\fluent"
WixQuietExec64:  既に存在するファイルを作成することはできません。
WixQuietExec64:  Error 0x80070001: Command line returned an error.
WixQuietExec64:  Error 0x80070001: QuietExec64 Failed
WixQuietExec64:  Error 0x80070001: Failed in ExecCommon method

[kenhys]

[daipom]

Thanks! I will review this again!

[daipom]

I have rebased this to apply

• 521

[ashie]

Install test seems failed since ab9df591684fc63283da50df695f05f5ff0ac373

Installing C:\fluentd\fluent-package\msi\repositories\fluent-package-5.0.0-x64.msi 
Start-Service : Cannot find any service with service name 'fluentdwinsvc'. 
At C:\fluentd\fluent-package\msi\install-test.ps1:7 char:1
+ Start-Service fluentdwinsvc
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (fluentdwinsvc:String) [Start-Se  
   rvice], ServiceCommandException
    + FullyQualifiedErrorId : NoServiceFoundForGivenName,Microsoft.PowerShell.  
   Commands.StartServiceCommand

[kenhys]

Redundant expression causes registration error. It will be fixed via 40bc79d.

[daipom]

Thanks! I will check the behavior of the package after CI finishes.