fluent / fluent-package-builder

td-agent (Fluentd) Building and Packaging System
Apache License 2.0
22 stars 25 forks source link

deb: reinforce test with systemd #497

Closed daipom closed 1 year ago

daipom commented 1 year ago

Add tests for migration from v4 and update to the future version.

daipom commented 1 year ago

Hmm, $ vagrant snapshot restore doesn't work on GitHub Actions... It works on my local Ubuntu Focal.

https://github.com/fluent/fluent-package-builder/actions/runs/5238249275

$ vagrant snapshot save -f debian-bullseye after-setup
==> debian-bullseye: Snapshotting the machine as 'after-setup'...
==> debian-bullseye: Snapshot saved! You can restore the snapshot at any time by
==> debian-bullseye: using `vagrant snapshot restore`. You can delete it using
==> debian-bullseye: `vagrant snapshot delete`.

$ vagrant snapshot restore debian-bullseye after-setup
==> debian-bullseye: Forcing shutdown of VM...
==> debian-bullseye: Restoring the snapshot 'after-setup'...

Progress: 0%
Progress: 90%
==> debian-bullseye: Checking if box 'bento/debian-11' version '202303.13.0' is up to date...
==> debian-bullseye: Resuming suspended VM...
==> debian-bullseye: Booting VM...
There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["startvm", "4099f22d-a3b5-4c56-8d80-bf17b78bd8a8", "--type", "headless"]

Stderr: VBoxManage: error: ahci#0: The target VM is missing a device on port 0. Please make sure the source and target VMs have compatible storage configurations [ver=9 pass=final] (VERR_SSM_LOAD_CONFIG_MISMATCH)
VBoxManage: error: Details: code NS_ERROR_FAILURE (0x80004005), component ConsoleWrap, interface IConsole
daipom commented 1 year ago

Hmm, $ vagrant snapshot restore doesn't work on GitHub Actions... It works on my local Ubuntu Focal.

I gave up using snapshot for now.

daipom commented 1 year ago

It is expected that 3 tests of the deb package fail at this point. These tests should succeed with #489.

daipom commented 1 year ago

I have commented out the tests that are not expected to succeed at this point. Those commenting out will be canceled in future fixes (such as #489) and will succeed.

kenhys commented 1 year ago
dpkg-deb -R /vagrant/debian/pool/bullseye/main/f/fluent-package/fluent-package_5.0.0-1_amd64.deb /vagrant/debian/pool/bullseye/main/f/fluent-package/fluent-package-dbgsym_5.0.0-1_amd64.deb tmp
dpkg-deb: error: --raw-extract takes at most two arguments (.deb and directory)

Type dpkg-deb --help for help about manipulating *.deb files;
Type dpkg --help for help about installing and deinstalling packages.
Error: Process completed with exit code 2.

could you take care to exclude dbgsym?

daipom commented 1 year ago
dpkg-deb -R /vagrant/debian/pool/bullseye/main/f/fluent-package/fluent-package_5.0.0-1_amd64.deb /vagrant/debian/pool/bullseye/main/f/fluent-package/fluent-package-dbgsym_5.0.0-1_amd64.deb tmp
dpkg-deb: error: --raw-extract takes at most two arguments (.deb and directory)

Type dpkg-deb --help for help about manipulating *.deb files;
Type dpkg --help for help about installing and deinstalling packages.
Error: Process completed with exit code 2.

could you take care to exclude dbgsym?

Sure! I'm checking it! I will fix it so that all the tests succeed.

kenhys commented 1 year ago

waiting CI.

daipom commented 1 year ago

Waiting CI...

kenhys commented 1 year ago

LTGM.

daipom commented 1 year ago

Thanks for your review!