fluent / fluent-package-builder

td-agent (Fluentd) Building and Packaging System
Apache License 2.0
22 stars 25 forks source link

Use new path for fluent-package #500

Closed kenhys closed 1 year ago

kenhys commented 1 year ago

No need to use old path for fluent-package.

kenhys commented 1 year ago

Need to rebase with #499

kenhys commented 1 year ago

failure on focal and jammy. checking....

kenhys commented 1 year ago

Hmm, postinst hook may not work as expected :thinking:

daipom commented 1 year ago

It sometimes fails in other PRs as well. (#501)

Is it possible that https://github.com/fluent/fluent-package-builder/pull/489#issuecomment-1587075397 problem still remains?

kenhys commented 1 year ago

Is it possible that #489 (comment) problem still remains?

There is a possibility of it. checking...

On local VM, update-from-v4.sh will succeed. :thinking:

kenhys commented 1 year ago

Try to run the failed job again.

kenhys commented 1 year ago

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet) maybe waiting appropriate time will work. :thinking:

daipom commented 1 year ago

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet) maybe waiting appropriate time will work. thinking

I wonder if this is the real cause of this problem.

I have tested the following 2 patterns on my local.

However, both patterns fail about 1 in 3 times.

It may be a good idea to add sleep or --wait option just in case, but perhaps it has nothing to do with this problem.

kenhys commented 1 year ago

However, both patterns fail about 1 in 3 times.

Thank you for checking. I'll investigate it again.

Anyway, using --wait option is better, I'll fix it.

kenhys commented 1 year ago

changed to use --wait option to sync.