Stop maintaining multiple copies of the same conf

daipom commented 1 year ago

Just refactoring. This does not change the result.

daipom commented 1 year ago

We need to do some fixes following this. I will do them after this PR.

Update the Fluentd config for Windows: #527
Update the following filepaths.
- /opt/fluent/share/td-agent.conf.tmpl: #528
- I think the filename should be fluentd.conf.default.
- /opt/fluent/share/td-agent-ruby.conf: #529
- we should remove this file because it is not used since #472

I have one question. Do we still need /opt/fluent/share/td-agent.conf.tmpl?

It is not used after the following PR:

but it is still better to have the default config under the /opt/fluent/share/, right?

daipom commented 1 year ago

Note: related fixes in the past:

ashie commented 1 year ago

but it is still better to have the default config under the /opt/fluent/share/, right?

I think so.

daipom commented 1 year ago

but it is still better to have the default config under the /opt/fluent/share/, right?

I think so.

Thanks!

daipom commented 1 year ago

Thanks for your review!

daipom commented 1 year ago

Done all TODO!

fluent / fluent-package-builder