fluent / fluent-package-builder

td-agent (Fluentd) Building and Packaging System
Apache License 2.0
22 stars 25 forks source link

deb: Stop using `--wait` option of systemctl #526

Closed daipom closed 1 year ago

daipom commented 1 year ago

We misunderstood the use of this option.

By default, systemctl status waits until the unit's start-up is completed (without --no-block option). The option --wait is for blocking systemctl start foobar until the service foobar is stopped.

daipom commented 1 year ago

Note: $ man systemctl on Ubuntu 22.04.

       --no-block
           Do not synchronously wait for the requested operation to finish. If this is not specified, the job will be verified, enqueued and systemctl will wait until the unit's start-up is completed. By passing this argument, it is
           only verified and enqueued. This option may not be combined with --wait.
       --wait
           Synchronously wait for started units to terminate again. This option may not be combined with --no-block. Note that this will wait forever if any given unit never terminates (by itself or by getting stopped explicitly);
           particularly services which use "RemainAfterExit=yes".

           When used with is-system-running, wait until the boot process is completed before returning.
daipom commented 1 year ago

Thanks for your review! I see!

The commit message and the issue comment is updated!

daipom commented 1 year ago

Thanks!