deb rpm: quote target files

[kenhys]

There was a case that missing quote about file name causes migration failures.

• No quote under /etc/td-agent/'PATH_WITH_SPACE'
• No quote under /var/log/td-agent/'PATH_WITH_SPACE'

Usually such files should not be generated, but need to care it in practical use case.

[daipom]

Thanks!

Are there file names that are not covered by this?

mv -f '/etc/<%= compat_package_dir %>/$d' '/etc/<%= package_dir %>/'

[kenhys]

mv -f '/etc/<%= compat_package_dir %>/$d' '/etc/<%= package_dir %>/'

It is not covered because of combination with for d in ... doesn't work as expected.

[daipom]

Oh, sorry. As you say, we can't use ' here. What about "?

mv -f "/etc/<%= compat_package_dir %>/$d" '/etc/<%= package_dir %>/'

[kenhys]

As #613 was merged, rebased with master.

[kenhys]

This looks good, but is there any reason you didn't use for d in $(ls /etc/<%= compat_package_dir %>)?

I've just overlooked that for d in "$(ls /etc/<%= compat_package_dir %>/)" would work.

[daipom]

We can omit more paths with for d in "$(ls /etc/<%= compat_package_dir %>/)", but I think the current codes are fine. Both would be fine.

[kenhys]

Thank you for reviewing!