fluent / fluent-package-builder

td-agent (Fluentd) Building and Packaging System
Apache License 2.0
21 stars 23 forks source link

github: extract test file as element of matrix #636

Closed kenhys closed 3 months ago

kenhys commented 3 months ago

Before:

test.sh execute multiple test files. This behavior make it hard to distinct failure test cases.

After:

Use test.sh as launch script. It doesn't execute multiple test files. This change was introduced to make it easy to distinct each test cases on error.

daipom commented 3 months ago

I have one concern. Wouldn't it make running tests in the local environment difficult?

I don't run tests on my local these days. This concern may be unnecessary. I have commented on this just in case.

Come to think of it, I was thinking that I could use grouping log lines feature to make the results easier to understand before.

I thought that this could be used as follows:

for test_filename in ${test_filenames[@]}; do
    echo -e "::group::Run test: $test_filename\n"
    ...
    echo "::endgroup::"
done
daipom commented 3 months ago

I have one concern. Wouldn't it make running tests in the local environment difficult?

I don't run tests on my local these days. This concern may be unnecessary. I have commented on this just in case.

Sorry, I don't think we need to worry too much about this point. When I run tests locally, I'm likely to run specific tests repeatedly. It may be enough to use CI to run all tests.

kenhys commented 3 months ago

Thanks,

Wouldn't it make running tests in the local environment difficult?

It may be. so it takes into account by $CI.

kenhys commented 3 months ago

Come to think of it, I was thinking that I could use grouping log lines feature to make the results easier to understand before.

I didn't know such a feature, Thanks!

kenhys commented 3 months ago

re-run stalled jobs.