search

fluent / fluent-package-builder

td-agent (Fluentd) Building and Packaging System
Apache License 2.0
21 stars 23 forks source link

test: fix experimental install test #655

Closed daipom closed 5 days ago

daipom commented 5 days ago

TARGET should not be used anymore.

The current test always installs the current latest version. After that, the test updates it to the experimental. So, the TARGET is meaningless, and the check always fails.

kenhys commented 5 days ago

test-verify-repo.sh is intended to be used to check whether repository metadata is correctly updated or not. (before deploying experimental to LTS)

To verify it, firstly current version is installed, then upgrade to experimental's latest version. If it can not be done correctly, we should not deploy them.

So, the TARGET is meaningless, and the check always fails.

No. it is required to ensure whether the specified version is installable or not.

daipom commented 5 days ago

I see! Sorry for confusing you. So, Target is the latest version in the experimental repo and means the expected version after the update.

./test-verify-repo.sh 5.0.4