fluent / fluent-plugin-kafka

Kafka input and output plugin for Fluentd
Other
303 stars 176 forks source link

out_rdkafka2: enable idempotency for kafka producers #501

Closed dipendra-singh closed 1 month ago

dipendra-singh commented 9 months ago

Which issue(s) this PR fixes: None.

What this PR does / why we need it: In order to enable Idempotency for kafka producers, rdkafka allowes us to enable this. (here)

Docs Changes: README.md : Added to usage template for better visibility.

Release Note: Same as the title.

ashie commented 9 months ago

Any rdkafka options can be set by rdkafka_options parameter. e.g.)

<match tag>
  @type rdkafka2
   rdkafka_options {                                                                                                                                        
     "enable.idempotence" : true
   }
   ....
</match>

Is there any reason to add a new specific parameter for idempotence?

dipendra-singh commented 9 months ago

@ashie To keep the consistency between this and other plugins. One needs to explore rdkafka options to have similar features to that of other plugins.

ashie commented 9 months ago

Ah, I see. Thanks for clarification. It seems reasonable.

https://github.com/fluent/fluent-plugin-kafka/blob/ea0f10a711a3cb49fba2a2c36dd3c3efa5b758ad/lib/fluent/plugin/out_kafka2.rb#L37

dipendra-singh commented 9 months ago

hey @ashie Can we close this?

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

ashie commented 1 month ago

Thanks for your contribution! I'm sorry for delay merging this.