Closed ttych closed 3 months ago
I just see #500, so this is not a safe way to do it this way.
and also, waterdrop encapsulation for rdkafka is just for producer side.
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days
I'm not sure yet but I agreed with reverting #513 to improve it.
In this approach, the border case should also follow in CI.
Reverted #513.
Thanks for your contribution! @ttych
All PR are failing now because of rdkafka gem update.
The current code works with rdkafka 0.12.0, and in 0.14.0 (there is no 0.13.0), the
Rdkafka::Producer
implementation has changed, no more@client
andRdkafka::Producer::Client
, now there is a@native_client
andRdkafka::NativeKafka
.No update on this part of the code between 0.14.0 and 0.15.0.
There is a constraint in the out_rdkafka2, on the
Rdkafka::Producer#close
, to add a timeout, which is not part of the standard gem.I try to update this behavior since following the current way to patch.
Thanks.