search

fluent / fluent-plugin-kafka

Kafka input and output plugin for Fluentd
Other
303 stars 176 forks source link

out_rdkafka2: add patch for new version of rdkafka #505

Closed ttych closed 1 month ago

ttych commented 9 months ago

All PR are failing now because of rdkafka gem update.

The current code works with rdkafka 0.12.0, and in 0.14.0 (there is no 0.13.0), the Rdkafka::Producer implementation has changed, no more @client and Rdkafka::Producer::Client, now there is a @native_client and Rdkafka::NativeKafka.

No update on this part of the code between 0.14.0 and 0.15.0.

There is a constraint in the out_rdkafka2, on the Rdkafka::Producer#close, to add a timeout, which is not part of the standard gem.

I try to update this behavior since following the current way to patch.

Thanks.

ttych commented 9 months ago

I just see #500, so this is not a safe way to do it this way.

and also, waterdrop encapsulation for rdkafka is just for producer side.

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

kenhys commented 1 month ago

I'm not sure yet but I agreed with reverting #513 to improve it.

kenhys commented 1 month ago

In this approach, the border case should also follow in CI.

kenhys commented 1 month ago

Reverted #513.

ashie commented 1 month ago

Thanks for your contribution! @ttych