fluent / fluent-plugin-kafka

Kafka input and output plugin for Fluentd
Other
303 stars 178 forks source link

feat(out_waterdrop): add basic waterdrop output plugin #508

Open raytung opened 7 months ago

raytung commented 7 months ago

This is a super simple proof-of-concept implementation for Waterdrop as described in https://github.com/fluent/fluent-plugin-kafka/issues/500. We'll need a lot more work to get this up to scratch compared to the other output plugins but I don't want to make this PR even larger :smile:

github-actions[bot] commented 3 months ago

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

cosmo0920 commented 3 months ago

This couldn't be included in v0.19.3 release. But can we mark as v0.20.0.rc milestone? This is because we have to seek successor of pure Ruby client for Kafka.

ashie commented 3 months ago

IMHO there is no problem merging this in any timing for make it as prototype of the new plugin and improve it step by step if we remove gem.add_dependency 'waterdrop', '~> 2.6'. Merging PoC code for new feature but disable by default is a common practice in large OSS projects such as Chromium or Firefox.