Closed aYukiSekiguchi closed 4 days ago
This will fix https://github.com/fluent/fluent-plugin-opensearch/issues/129
It looks like there is no test case for @_aws_credentials
and aws_credentials()
. I don't create a testcase for the exception. Sorry.
@aYukiSekiguchi san, I really appreciate the PR. Could you please check and fix the failing test cases? I kind of waiting for this to be merged.
@akhil31415
I'm not very familiar with GitHub Actions, so I might be mistaken.
The installation path is insecure. Bundler cannot continue.
/opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/gems/3.2.0/gems is world-writable (without sticky bit).
Bundler cannot safely replace gems in world-writable directories due to potential vulnerabilities.
Please change the permissions of this directory or choose a different install path.
Error: Process completed with exit code 38.
@_aws_credentials
.begin
/ rescue
to the @_aws_credentials
code, this has decreased the branch coverage.Sorry for our less activity in this plugin. We are queuing this as our next task, will tackle on it next week.
Thank you for retrying. It looks like there is a bug in .github/workflows/linux.yml
. I have submitted a PR to fix the issue: PR #143.
Hi, I merged you fixing Linux workflow PR. Could you rebase off master?
Thank you. I have rebased this PR. The error with Ruby 3.2 on Ubuntu has been fixed. Only the coverage/coveralls issue remains.
Sorry to rush, but is there any ETA on merging/releasing this change? Thanks!
@ashie @kenhys @daipom Could y'all take over this PR?
Sorry for any confusion.
I'm waiting for the committer to decide whether the Coveralls failure, which decreased coverage, is acceptable. Some recent commits to the main branch also failed Coveralls, so I think this is sometimes acceptable.
It seems that PR itself is reasonable but it might be better to add test case for it in assured. I'll look into it.
MEMO: it is enough that mock aws_credentials and raise RuntimeError in second call, then assert existence of error log message.
If
aws_credentials()
fails due to an unstable network or other issues, it throws an exception. This stopstimer_execute()
from repeating its block, preventingOpenSearchOutput
from updating@_aws_credentials
. As a result,@_aws_credentials
will expire.This commit catches the exception and prevents it from propagating to
timer_execute()
, ensuring continuous credential updates.