search

fluent / fluent-plugin-prometheus

A fluent plugin that collects metrics and exposes for Prometheus.
Apache License 2.0
258 stars 79 forks source link

Restricts prometheus-client version #120

Closed ganmacs closed 5 years ago

ganmacs commented 5 years ago

hotfix for https://github.com/fluent/fluent-plugin-prometheus/issues/119

New version(0.10.0) has no compatibility with an older version.

This is a temporary solution. We need to catch up new version of prometeus-ruby.

kazegusuri commented 5 years ago

I will check in this weekend.

duxthefux commented 5 years ago

@kazegusuri When can we expect the fixed version? This currently breaks our autoscaling in production.

Our temporary fix currently is td-agent-gem install fluent-plugin-prometheus && td-agent-gem install prometheus-client -v 0.9.0 && td-agent-gem uninstall prometheus-client -v 0.10.0

TBH: this is some serious issue which will affect many people using this plugin in production. Would really appreciate it if it could be merged and a new release created.

repeatedly commented 5 years ago

td-agent-gem install fluent-plugin-prometheus && td-agent-gem install prometheus-client -v 0.9.0 && td-agent-gem uninstall prometheus-client -v 0.10.0

Please install prometheus-client first. No need uninstall step.

repeatedly commented 5 years ago

I just released v1.6.1 because prometheus plugin is popular. cc: @kazegusuri

repeatedly commented 5 years ago

close via #121

duxthefux commented 5 years ago

thanks a lot!!!!

ganmacs commented 5 years ago

There is no guarantee 0.9.0(this version has not been released and may not going to be released) has compatibility with 0.4.2 or older versions...