search

fluent / fluent-plugin-prometheus

A fluent plugin that collects metrics and exposes for Prometheus.
Apache License 2.0
258 stars 79 forks source link

Fix for v1.4.0 prometheus-client dep #123

Closed CVirus closed 5 years ago

CVirus commented 5 years ago

v1.4.0 is broken after prometheus-client update. Unfortunately, you don't have a version branch that I can create the PR to. Please create one and I'll re-create the PR.

Signed-off-by: Mohamed Hazem mhaz@hellofresh.com

ganmacs commented 5 years ago

We have no plan to backport this. Please update fluent-plugin-prometheus version to 1.6.1 which has the same change as this. Or you can specify the version of promethues-client in your Gemfile.

repeatedly commented 5 years ago

Does breaking compatibility exist between fluent-plugin-prometheus 1.4 and 1.6?

ganmacs commented 5 years ago

https://github.com/fluent/fluent-plugin-prometheus/compare/fc060aa...aaef57a777a3732438652d5320dcd29bfc04299a

I can't say there is surely no breaking change. but it seems ok to me.