search

fluent / fluent-plugin-prometheus

A fluent plugin that collects metrics and exposes for Prometheus.
Apache License 2.0
258 stars 79 forks source link

undefined method `prepare_placeholders` #143

Closed SuperQ closed 4 years ago

SuperQ commented 4 years ago

We're getting an error when deploying 1.7.2 upgrading from 1.7.0.

/opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-prometheus-1.7.2/lib/fluent/plugin/in_prometheus_tail_monitor.rb:32:
in `configure': undefined method `prepare_placeholders' for #<Fluent::Plugin::Prometheus::ExpandBuilder:0x00007f092085d628> (NoMethodError)

It looks like this is coming from the new code in https://github.com/fluent/fluent-plugin-prometheus/pull/139.

repeatedly commented 4 years ago

@ganmacs Could you check this issue? We are now building td-agent 3.6.0. This affects it.

ganmacs commented 4 years ago

https://github.com/fluent/fluent-plugin-prometheus/pull/144 should fix this issue.

ganmacs commented 4 years ago

Thank you for your feedback! I've released v1.7.3 https://rubygems.org/gems/fluent-plugin-prometheus/versions/1.7.3