search

fluent / fluent-plugin-prometheus

A fluent plugin that collects metrics and exposes for Prometheus.
Apache License 2.0
258 stars 79 forks source link

Please bind on IPv4 & IPv6 by default #151

Closed stv0g closed 4 years ago

stv0g commented 4 years ago

Can we replace the following default argument 0.0.0.0 by ::?

https://github.com/fluent/fluent-plugin-prometheus/blob/b27de0a17093815107293575671835f72467786f/lib/fluent/plugin/in_prometheus.rb#L13

ganmacs commented 4 years ago

I don't think so. Is there any reasonable reason we should change?

stv0g commented 4 years ago

Yes definitly. We should encourage everybody to deploy their new services and network via IPv6.

Such small changes make it easier. We should treat them equal at least. Why listen on IPv4 by default only?

https://www.worldipv6launch.org/

stv0g commented 4 years ago

Btw. I am not saying that we should not listen on IPv4 anymore. Replacing 0.0.0.0 with :: will cause the socket to listen on IPv4 and IPv6

ganmacs commented 4 years ago

It's breaking change. if users already use the address in ipv6, they get something port conflict error because this plugin starts to listen to a new port. So we have to avoid it as much as possible.

stv0g commented 4 years ago

Alright, I will close the PR.

Sad to see that all new IPv6 users will fall in the same pitfall as me.

NoctivagusObitus commented 1 year ago

Quite some time ago by now but I like to mention falling in exactly that pitfall.