search

fluent / fluent-plugin-prometheus

A fluent plugin that collects metrics and exposes for Prometheus.
Apache License 2.0
258 stars 79 forks source link

Add throttling metrics #227

Closed Athishpranav2003 closed 2 months ago

Athishpranav2003 commented 2 months ago

Issues this PR solves

190

Why is this PR needed?

Add observability on throttling in in_tail plugin https://github.com/fluent/fluentd/pull/4578 - corresponding metrics PR in in_tail

Athishpranav2003 commented 2 months ago

@ashie this is dependent on https://github.com/fluent/fluentd/pull/4578

Like the above PR is merged, but whoever didn't update Fluentd will have error if they use this code (since the metrics reference is dangling).

What's your suggestion for it?

ashie commented 2 months ago

Like the above PR is merged, but whoever didn't update Fluentd will have error if they use this code (since the metrics reference is dangling).

What's your suggestion for it?

Please check existence of monitor_info.throttled. FYI: https://github.com/fluent/fluent-plugin-prometheus/pull/202/files#r964327028

Athishpranav2003 commented 2 months ago

@ashie I will add the manual testing info once i get time

Athishpranav2003 commented 2 months ago

image output

Athishpranav2003 commented 2 months ago

@ashie any other checks do you want me to do?

ashie commented 2 months ago

Thanks!