search

fluent / fluent-plugin-s3

Amazon S3 input and output plugin for Fluentd
https://docs.fluentd.org/output/s3
314 stars 218 forks source link

remove a feature request leaking into the README #285

Closed mburns closed 5 years ago

mburns commented 5 years ago

reverts #188

... which added what appears to be a feature request in the form of a sub-heading in the project readme.

The readme doesn't seem like the right place for this (maybe better as an Issue), and is confusing to readers trying to learn about the project.

mburns commented 5 years ago

rfr @ganmacs

ganmacs commented 5 years ago

The readme doesn't seem like the right place for this (maybe better as an Issue)

thank you for your contribution. You're right. Look good to me. BTW, could you follow DCO? https://github.com/fluent/fluent-plugin-s3/pull/285/checks?check_run_id=197460290

@repeatedly what do you think of it? I completely agree with this change. I think that these kinds of information should be at issue, not README. if you don't have any concerns, I'll merge this and create a new issue about Ceph s3.

repeatedly commented 5 years ago

this patch no problem for me

ganmacs commented 5 years ago

thank you!!