search

fluent / fluent-plugin-s3

Amazon S3 input and output plugin for Fluentd
https://docs.fluentd.org/output/s3
314 stars 218 forks source link

First pass at adding AssumeRoleWebIdentity creds #307

Closed mothershipper closed 4 years ago

mothershipper commented 4 years ago

We wanted to run this plugin on EKS. Instead of acting like kiam or kube2iam, EKS creates a web token identity file within a container that allows the application to assume roles -- but using the newer credential provider.

This commit adds a web_identity_credentials config section and handler so we can use the identity file within EKS.

mothershipper commented 4 years ago

We're testing this in our EKS cluster today. I still want to verify the new config works before this is ready to go :)

mothershipper commented 4 years ago

Ok, confirmed, this works in our clusters

repeatedly commented 4 years ago

Proposal is good. After apply ganmacs reviews, we will merge and release new version.

mothershipper commented 4 years ago

Thanks @ganmacs and @repeatedly for the review, I really appreciate the quick response!

I pushed another commit with what I think will address your concerns. If it looks good, I can squash, or you're welcome to squash and merge.

repeatedly commented 4 years ago

sorry for the late. Just merged. I will release new version soon.