Use IAM API credentials when assuming a role. Fixes #330

fluent / fluent-plugin-s3

Amazon S3 input and output plugin for Fluentd

https://docs.fluentd.org/output/s3

314 stars 218 forks source link

Use IAM API credentials when assuming a role. Fixes #330 #356

Closed jotes closed 3 years ago

jotes commented 4 years ago

Hi, Disclaimer: I'm not a ruby developer.

The PR fixes the issue mentioned in #330. I had added a couple of unit tests to check the existing functionality and noticed a few strange things e.g. I couldn't find the place in which @region gets initialized, some of conditions are probably redundant (?). I would appreaciate a thorough review :) Thanks in advance!

repeatedly commented 3 years ago

Sorry. I forgot to merge this patch. I will release new version soon.

agup006 commented 3 years ago

Hey @jotes, congrats on your first merged PR 🎉 Nice work 👍 Please let me know if we can be helpful in any way.