fluent / fluent-plugin-s3

Amazon S3 input and output plugin for Fluentd
https://docs.fluentd.org/output/s3
314 stars 218 forks source link

Add event bridge mode #403

Closed funtusov closed 2 years ago

funtusov commented 2 years ago

This PR adds the SQS event bridge mode

rezonick commented 2 years ago

Hi, I'll describe a little bit more regarding the PR. There few ways to notify a newly created object in the S3 bucket to SQS:

  1. S3 notifications: the legacy and already support by 'fluent-plugin-s3' way.
  2. EventBridge rule: the format of the event is a little bit different.

References:

ori-rezonate commented 2 years ago

We would love this to be merged :-) Thanks!

ozzycore commented 2 years ago

This is a very useful integration :) Is there any estimate for when this might be merged?

rezonick commented 2 years ago

Hi, I opened a PR to funtusov:event_bridge_mode, updated the docs/input.md as requested :)

ashie commented 2 years ago

@rezonick Hmm, DCO check is failed: https://github.com/fluent/fluent-plugin-s3/pull/403/checks?check_run_id=8820393195 We need to revise the commit.

Could you create a revised commit with Signed-off: field in your commit message, then let me know the branch? I'll force push it to this PR.

rezonick commented 2 years ago

Sure :) that's the branch (rezonick:fix-dco-signoff)

Thank you!

rezonick commented 2 years ago

Hi, I followed the instruction on fixing the DCO issue, will you be able to force push it or I did something wrong?

Thanks :)

Screen Shot 2022-10-18 at 10 07 58

ashie commented 2 years ago

Thanks!