search

fluent / fluent-plugin-s3

Amazon S3 input and output plugin for Fluentd
https://docs.fluentd.org/output/s3
314 stars 217 forks source link

Update documentation in the instance_profile_credentials section #426

Closed fumihumi closed 1 year ago

fumihumi commented 1 year ago

I asked a question on Discussion (ref: https://github.com/fluent/fluentd/discussions/4236) the other day, and after examining the commit log I found the following

Although aws_iam_retries is already deprecated, I found the following commit in the commit log for this line.

config_param :aws_iam_retries, :integer, default: nil, deprecated: "Use 'instance_profile_credentials' instead."

ref: https://github.com/fluent/fluent-plugin-s3/blame/master/lib/fluent/plugin/out_s3.rb#L87

commit: https://github.com/fluent/fluent-plugin-s3/commit/11e8ad76a38d59177bf2ce1435c5bdcdb7f16e67

I thought the above commit was omitting an update to the Document.

ashie commented 1 year ago

refs:

You are right, it was changed to suppress deprecation warnings. Thanks for your contribution!