fluent / fluentd-kubernetes-daemonset

Fluentd daemonset for Kubernetes and it Docker image
Apache License 2.0
1.26k stars 982 forks source link

Dedot implicitly removed from v1.16/debian-logzio #1442

Open b-hub opened 1 year ago

b-hub commented 1 year ago

As of v1.16/debian-logzio, the default dedot filtering is no longer applied, so labels and annotations are now sent to logzio without their dots being replaced by underscores.

This looks to have been introduced between v1.15 and v1.16, where there was an upgrade for fluent-plugin-kubernetes_metadata_filter 2.13.0 to 3.2.0 (see the diff here) - was this known / intended?

fluent-plugin-dedot_filter now appears to be an explicit dependency for some of the other images (e.g. elasticsearch8) - https://github.com/fluent/fluentd-kubernetes-daemonset/blob/master/templates/Gemfile.erb#L32.

Could fluent-plugin-dedot_filter be added to Gemfile for logzio as well?

The logzio-k8s image has also added this in as a Gem, however it is on an older version of the fluentd-kubernetes-daemonset.

Thanks