search

fluent / fluentd-kubernetes-daemonset

Fluentd daemonset for Kubernetes and it Docker image
Apache License 2.0
1.25k stars 981 forks source link

Add v1.17.0-1.0 images #1495

Closed kenhys closed 1 week ago

kenhys commented 3 weeks ago

As fluent-plugin-kubernetes_metadata_filter has supported fluentd v1.17.0 since 3.5.0.

kenhys commented 1 week ago

workflow should be modified after #1496 has been merged.

kenhys commented 1 week ago

Updated target for v1.17 in workflow. and re-generated dockerfiles.

daipom commented 1 week ago

Sorry, I can't find how to manage plugins/ in MAINTAINING.md and don't understand it. Do we need to manually create the corresponding empty directories?

kenhys commented 1 week ago

Thanks, they should be removed.

kenhys commented 1 week ago

plugins/v1.17 is treated as template and copy to docker-image/v1.17/ each images by plugins rule in Makefile. thus plugins has to be manually created every new v1.1x release.

https://github.com/fluent/fluentd-kubernetes-daemonset/blob/b75789ce4e9bd53044177597a972cfdd440b6201/Makefile#L354-L371

daipom commented 1 week ago

Do we need these files?

* `docker-image/v1.17/{,arm64/}debian-elasticsearch6/`

* `docker-image/v1.17/{,arm64/}debian-stackdriver/`

The arm64 files remain. Shouldn't we remove those files as well?

kenhys commented 1 week ago

Thanks, that's right. I've remove it too.