Open bennettfalkenberg opened 9 months ago
I believe that this commit may have introduced this issue. https://github.com/fluent/fluentd/commit/afee4a4861e0e6e0c43cd021e55baac89e4a1d50#diff-6042a07157b33b2d729ab3d10ed6bba89ad5f71aaed2be1aeb22a179a45ebbae
I see a number of issues that are "waiting-for-triage", just curious how often the community checks in on these issues?
We have found a resolution - Re-adding old code from a previous commit has resolved the issue.
This class needed to be re-added to Supervisor.rb: class LoggerInitializer
This allows the $log variable to be properly initialized, and the error when running --daemon flag no longer occurs.
A real fix to this would be great, i'm sure we are adding back a lot of dead code here.
Thanks for your report! We'll check this.
BTW running as a service is recommended on Windows instead of --daemon
option:
https://docs.fluentd.org/installation/install-by-msi#step-5-run-fluentd-as-windows-service
I'm sorry.
This breaks Windows --daemon
feature since v1.16.0.
This should be fixed.
From #4065
Supervisor.load_config()
is called in ServerEngine's reloading function, but Fluentd doesn't use the function even whenSIGHUP
orSIGUSR2
. So I can't see the reason for initializing the logger in that callback.
This is wrong.
It was used daemon.rb
, which is used only for Windows daemon.
I may have overlooked the Windows daemon use case, as I assumed it was supposed to use Windows services on Windows. However, I can confirm Windows daemon seems to work correctly on v1.15.3.
We need to fix this so that it works again.
This is not ready for v1.16.4.
@daipom Thank you for the attention to this bug!
Describe the bug
When running td-agent from command line on Windows with the --daemon flag, we are getting the following error:
The same run configuration works on Linux systems
To Reproduce
Run td-agent from command line with --daemon flag set to a pidfile. Our exact command:
Expected behavior
for fluentd to properly launch with the pidfile specified
Your Environment
Your Configuration
Your Error Log
Additional context
Like said above, the command works on Linux systems just fine, just not on Windows systems for some reason