search

fluent / helm-charts

Helm Charts for Fluentd and Fluent Bit
Apache License 2.0
366 stars 438 forks source link

feat(fluent-bit): Added support for ingress.annotations tpl rendering and image pull policy change #476

Closed rgaduput closed 3 months ago

rgaduput commented 3 months ago
rgaduput commented 3 months ago

@stevehipwell the idea was to create tpl function which will support any input type and it can be reused in the chart if required. any case , i have pushed your suggestion. Thanks.

rgaduput commented 3 months ago

@stevehipwell thanks, I have implemented your suggestion along with the Chart.yaml changes. Yes i did the local tests, and it works as expected.

stevehipwell commented 3 months ago

Thanks @rgaduput this PR looks good, but I think it might be worth adding the change from #479 before it's approved/merged to limit the number of chart releases.

rgaduput commented 3 months ago

@stevehipwell done, both are combined in this PR now.

rgaduput commented 3 months ago

closes: #478

stevehipwell commented 3 months ago

@patrick-stephens do you know why GH Actions might not be working correctly here? I've not seen a blip on the status page and all of the other repos I'm currently interacting with are fine.

patrick-stephens commented 3 months ago

Just checking on mobile and I can't see any issue, What's the problem?

stevehipwell commented 3 months ago

@patrick-stephens it just hung for a reasonable period, I wasn't sure if there was an org issue or not. Looks like it was just another distributed system consistency issue (AKA undocumented failure).

stevehipwell commented 3 months ago

@patrick-stephens it actually looks like it is org based (the chart release action is also waiting), I suspect the GitHub shard Fluent is on is having runner availability issues.