fluent / helm-charts

Helm Charts for Fluentd and Fluent Bit
Apache License 2.0
366 stars 438 forks source link

limits the length of the grafana dashboard uid to 40 to prevent grafa… #509

Closed mheers closed 3 weeks ago

mheers commented 1 month ago

…na import error

When trying to import the dashboard json the grafana container throws logger=provisioning.dashboard type=file name=file t=2024-05-23T06:54:30.144967684Z level=error msg="failed to save dashboard" file=/tmp/dashboards/fluentbit-fluent-bit-fluent-bit.json error="uid too long, max 40 characters"

With this fix the length of the uid is trunctated to 40 chars.

stevehipwell commented 1 month ago

Isn't the output of sha256sum fixed length?

CC @captainpro-eng

mheers commented 1 month ago

It is fixed to 64 chars and so too long for grafana

captainpro-eng commented 1 month ago

Isn't the output of sha256sum fixed length?

CC @captainpro-eng

hi, can we remove this imp. , I was using old Grafana where if I set uid null not generating unique uid. After upgrading Grafana if we pass null it is working.

marcofranssen commented 1 month ago

Would be great to get this fix in or as an alternative we simply do not define the uid in the dashboard. Both solutions work, tested in my own setup.

stevehipwell commented 1 month ago

@mheers could you please update this PR to set the uid field to null and remove the fluent-bit.dashboard.uid function added in #503.

mheers commented 1 month ago

@stevehipwell done

stevehipwell commented 1 month ago

@mheers could you rebase this PR?

mheers commented 1 month ago

@stevehipwell rebased and cleaned history

marcofranssen commented 1 month ago

@mheers the dco is failing. Maybe fix that to not delay the release of this fix

mheers commented 1 month ago

@marcofranssen fixed. thanks

stevehipwell commented 4 weeks ago

@mheers you need to update the version and release notes annotations in Chart.yaml so the workflows will pass.

mheers commented 4 weeks ago

@stevehipwell updated