search

fluentassertions / fluentassertions.mvc

Fluent Assertions extensions for ASP.NET MVC
Microsoft Public License
35 stars 10 forks source link

Add JsonResult assertions #10

Closed kevinkuszyk closed 6 years ago

sharpjs commented 10 years ago

I have a class I am using for this purpose. I will put together a PR to add it into Fluent Assertions.

kevinkuszyk commented 10 years ago

Great. Looking forward to seeing it.

kevinkuszyk commented 9 years ago

@sharpjs any chance you can commit this to a branch on your fork? I have some time coming up so I may be able to finish this off.

jamiehumphries commented 9 years ago

I was going to maybe take a look at this (because I wanted it on my project :smile:) and/or some of the other similar ones like #9, #20, #21. Are there any guidlelines on style, documentation or general contribution that I should have a look at? Or should I just try to keep in line with what is already here?

kevinkuszyk commented 9 years ago

@jamiehumphries great. Just try to follow the existing style and @dennisdoomen's code guide lines. Also, make sure you have tests in the AAA format for each feature.

Feel free to open pull requests early if you want any feedback or code review. I'm finishing work for 2 weeks today, so please bear with me if I'm a little slow in replying over the holidays.

jamiehumphries commented 9 years ago

Great, thanks. I'll hopefully have a look at a few of these over the Christmas break.

kevinkuszyk commented 6 years ago

Closed via #37. Thanks @rikrak!