Closed schambers closed 6 months ago
@jzabroski or @eloekset, Are you good with me merging this? I noticed the build failed but it seemed unrelated and I don't believe I have access to ADO to attempt to restart the build
It looks like the documentation is failing to build for some reason. Let's first look into that before merging, but the plan is that this is 'functionally approved to be merged'. I think it's awesome.
Are you able to grant me access to retry the build by chance?
I queued it up. Commuting. Maybe around 9pm est
I believe I fixed the issue. I believe Ubuntu-latest no longer installed dotnet by default
@eloekset im not sure why it's not using the latest pipelines yaml? Is there a trick to getting a failed PR check to use the latest yaml pipeline? I swear I thought that this would just work.
In any case, I plan to remove the change I made to the yaml as I realized it was incorrect and the real fix was to update global.json - I'll also add a comment before that step that if the sdk is not found, to check global.json
@eloekset Think I figured it out. I made the master branch protected here and it gave me the option to rebase this PR to the head of master.
I believe this is the correct manner of adding new docs. Unsure if there's any steps needed for generating docs.