search

fluentpython / example-code

Example code for the book Fluent Python, 1st Edition (O'Reilly, 2015)
http://bit.ly/fluentpy
MIT License
5.56k stars 2.18k forks source link

Remove charset from CONTENT_TYPE from http_charfinder.py in chapter18 #13

Open ResolveWang opened 7 years ago

ResolveWang commented 7 years ago

In the recent version of aiohttp(v2.x), the default value of charset is utf-8, if we use

CONTENT_TYPE = 'text/html; charset=UTF-8'

The code will raise the exception below

ValueError: charset must not be in content_type argument

This PR removes the charset since its default value is utf-8.

ScottyNZ commented 6 years ago

Also, if using python 3.6+ need to change **vars(descr) to **descr._asdict()

ramalho commented 6 years ago

Thank you both for this contribution. I have not yet started working on a 2nd edition of Fluent Python. Almost all the issues (like this one) are related to breaking changes that happened in asyncio, which was a provisional package in Python 3.4 when I wrote the book. I have since fixed some of the asyncio examples that I use in talks or courses, only to seem them break again in the next release. So my current plan is to review your contributions only when I actually start working on the 2nd edition of the book. I appreciate your contributions and I will let you know when they are added to the new edition.