fluentpython / example-code

Example code for the book Fluent Python, 1st Edition (O'Reilly, 2015)
http://bit.ly/fluentpy
MIT License
5.56k stars 2.18k forks source link

Mod : Example 16-17 grouper optimization #5

Open lbbc1117 opened 7 years ago

lbbc1117 commented 7 years ago

The delegating generator grouper delegates averager inside a while loop. Every time averager returns, a new but useless averager instance will be created during the following loop period. Adding a yield statement after yield from averager() without while loop would be better. Great great book, by the way.

austinbravo commented 4 years ago

@ramalho i think the example should be this. currently, a new delegating generator is created for each item in data, which makes grouper's while loop unnecessary and creates the unused averager instance. grouper is also still active when the results are reported, though not sure if this matters as will be garbage collected once main() returns.

def grouper(results):
    while True:
        key = yield
        results[key] = yield from averager()

def main(data):
    results = {}
    group = grouper(results)
    next(group)
    for key, values in data.items():
        group.send(key)
        for value in values:
            group.send(value)
        group.send(None)
    group.close() # just to highlight that grouper is still an active generator

    report(results)