search

fluentribbon / Fluent.Ribbon

WPF Ribbon control like in Office
http://fluentribbon.github.io
MIT License
2.56k stars 517 forks source link

Detach from KeyDown event to match code in Show() #1004

Closed developersthinksmartbox closed 2 years ago

developersthinksmartbox commented 2 years ago

As written, Backstage will attach to the KeyDown event of the owning window but later detach from the PreviewKeyDown event. This creates a memory leak where the Backstage instance (and everything else referenced from it) will be kept in memory for as long as the owning window, via the KeyDown event. In our application the appearance of the main window changes according to which mode the application is in, with the ribbon control part of the visual tree in only one of these modes. In this (perhaps slightly unusual) setup, simply opening the backstage will cause the application to leak memory. This PR aims to solve this problem by detaching from the KeyDown event in RestoreParentProperties as was, presumably, the original intent.

batzen commented 2 years ago

Will try to release a new version tomorrow. Thanks for contributing!