fluentribbon / Fluent.Ribbon

WPF Ribbon control like in Office
http://fluentribbon.github.io
MIT License
2.54k stars 518 forks source link

Rounded corners are missing in recent alpha builds #1111

Closed andyld97 closed 1 year ago

andyld97 commented 1 year ago

Hi,

recently I kept upgrading the nuget packages for my app since I am using the alpha versions anyway, but my RibbonWindow has no more rounded corners (setting CornerPreference="Round" helps neither). I know that it worked with the following versions:

If I am switching back to both "old" versions, my rounded corners are back.

How it looks currently: grafik


Environment

batzen commented 1 year ago

Can't reproduce using the current dev version. Just published a new preview (10.0.0-alpha0256). Could you try that one?

batzen commented 1 year ago

Ah, just noticed that you already used the version from the appveyor feed. Could you have a look at which ControlzEx version got resolved in your case? I published a new preview of that to nuget a few minutes ago.

andyld97 commented 1 year ago

I just tested Fluent.Ribbon.Showcase-v10.0.0-alpha0256 and there are rounded corners. The version of ControlzEx is 6.0.0.272.

I think I have a clue, I compared the ShowCase MainWindow.xaml with mine and I noticed that I had set WindowStyle="None" due to the last issue with the window border. If I am removing it, my rounded corners are back. So I guess it's related to the WindowStyle (None).

batzen commented 1 year ago

WindowStyle = None means, no native window border. If you still want to have a border you'll have to use the glow border. Just set PreferDWMBorderColor="False" and CornerPreference="DoNotRound". The glow border does not support rounded corners.

andyld97 commented 1 year ago

Thank you for claryfing this, so removing WindowStyle="None" works just fine for me!