fluentribbon / Fluent.Ribbon

WPF Ribbon control like in Office
http://fluentribbon.github.io
MIT License
2.48k stars 515 forks source link

Enhanced FocusVisual for various controls #1112

Closed cbra-caa closed 1 year ago

cbra-caa commented 1 year ago

792

Improved the visual cue for textboxes when getting keyboard focus by using the full theme color.

Improved the FocusVisualStyle for the other controls to follow the WCAG recommendations. https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html

If this is to be improved further, the next step would be to make the controls taller in general, or add more spacing between the elements in the ribbon. As it is right now the textbox, f.ex. cant increase the size of its border without pushing nearby controls 😅

batzen commented 1 year ago

Just had a look at this. IMHO it's way too much for certain cases.

I guess it would look way better if it had a narrower dotted border, instead of a rectangle with a 2 px stroke. Just like the default focus visual, but with correct colors for dark/light.

cbra-caa commented 1 year ago

I tried to base the solution off of the newest version of Office (2021). There every control has a 2px solid border when focused, even including textboxes and comboboxes. Should I continue with the solid line, or use the striped one?

From Word 2021 f.ex.: Combobox - writeable: image

Combobox: image

Spinner: image

Button: image

Backstage: image

batzen commented 1 year ago

Thanks for contributing!