fluentribbon / Fluent.Ribbon

WPF Ribbon control like in Office
http://fluentribbon.github.io
MIT License
2.48k stars 515 forks source link

RibbonBackButton - Localization Mix #1161

Closed robertmuehsig closed 10 months ago

robertmuehsig commented 10 months ago

The "BackButton" on the Backstage has a flaw, that it mixes languages and the localization is "not ideal".

This button here: image ... work with a screenreader since this change.

Unfortunately the German translation is "not ideal", because of the Wording "Backstage schließen". "Backstage" itself is used by Microsoft even in German support sites, but our accessibility tester doesn't allow this, because NVDA, Jaws & the Windows Narrator have a weird pronunciation of it.

I checked if I could change the title myself to "Menü schließen", which doesn't sound too bad, but the screenreader will read "Menü schließen - Button - Open Backstage", which is weird.

The "Open Backstage" originates from the RoutedUICommand:

image, which is currently hardcoded:

public static class RibbonCommands
{
    /// <summary>
    /// Gets the value that represents the Open Backstage command
    /// </summary>
    public static readonly RoutedCommand OpenBackstage = new RoutedUICommand("Open backstage", nameof(OpenBackstage), typeof(RibbonCommands));
}

The "easiest" fix would be to change the "Backstage" to "Menü" (for the German translation) and somehow use the same text for the RoutedUICommand, but I'm not even sure if this is needed or if the text could be removed anyway.


Environment

robertmuehsig commented 10 months ago

@batzen Ah - the "ESC" Key makes sense in this area, but the button text is still "Backstage schliessen" - any chance that you might switch to "Menü schliessen" instead?

batzen commented 10 months ago

You can overwrite that text by changing BackButtonUid. 😉

robertmuehsig commented 10 months ago

Stupid question: How can I access this property from my code? In the past I used something to traverse the WPF control tree, but this seems “dirty”.

Am 22.08.2023 um 22:05 schrieb Bastian Schmidt @.***>:



You can overwrite that text by changing BackButtonUid. 😉

— Reply to this email directly, view it on GitHubhttps://github.com/fluentribbon/Fluent.Ribbon/issues/1161#issuecomment-1688849397, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFYXXZKRBGO7SJYZZRNRY3XWUGH3ANCNFSM6AAAAAA3YSLYC4. You are receiving this because you authored the thread.Message ID: @.***>

batzen commented 10 months ago

It's a property on BackstageTabControl.

robertmuehsig commented 10 months ago

@batzen Thanks - didn't noticed it, but works! Any chance that you might publish the 10.0.3 soon?

batzen commented 10 months ago

Will try to publish tomorrow.