search

fluentribbon / Fluent.Ribbon

WPF Ribbon control like in Office
http://fluentribbon.github.io
MIT License
2.48k stars 515 forks source link

feat: add style keys for some ribbon controls #1178

Closed nishy2000 closed 8 months ago

nishy2000 commented 8 months ago

Fix Issue #1177.

I added a style key for the ribbon control. This is to allow for the creation of custom styles based on the original ribbon control style.

At the same time, key names for styles and templates with different naming conventions have been corrected.

Key names added or changed are as follows.

Old New
--- Fluent.Ribbon.Styles.ApplicationMenu
Fluent.Ribbon.Templates.ApplicationMenuButton Fluent.Ribbon.Templates.ApplicationMenu
--- Fluent.Ribbon.Styles.ColorGallery
Fluent.Ribbon.Styles.RibbonComboButton Fluent.Ribbon.Styles.ComboBox.ToggleButton
--- Fluent.Ribbon.Styles.ComboBox
Fluent.Ribbon.Templates.RibbonComboButton Fluent.Ribbon.Templates.ComboBox.ToggleButton
Fluent.Ribbon.Templates.RibbonCombobox Fluent.Ribbon.Templates.ComboBox
--- Fluent.Ribbon.Styles.InRibbonGallery
--- Fluent.Ribbon.Styles.RadioButton
--- Fluent.Ribbon.Styles.RibbonMenu
--- Fluent.Ribbon.Styles.TextBox
--- Fluent.Ribbon.Styles.ScrollBar
--- Fluent.Ribbon.Styles.StatusBar
--- Fluent.Ribbon.Styles.StatusBarMenuItem
--- Fluent.Ribbon.Styles.WindowCommands
nishy2000 commented 8 months ago

Hi, @batzen

I think the "Breaking Change" is that I have changed the existing key names. Is it possible to have it applied to v10 series (not v11 series) if I only add new key names and do not rename the existing key name? If yes, I will push a new commit that does not change the existing key names.

batzen commented 8 months ago

Hi @nishy2000

changing something that might have been previously used by users/consumers is a breaking change. Just adding new keys is, of course, no breaking change. ;-) If you change the PR to just add new keys i could include it in the next minor version (10.1) update. New keys are a new "feature" so i have to increase the minor version, instead of just the patch version. But that's no problem.

You could create a separate PR where you rename the keys and base it off of the branch "features/new_office_theme" instead of the develop branch as the office theme branch is the one i am currently working on features for version 11.

nishy2000 commented 8 months ago

Hi @batzen

Sounds good.

I pushed the new commit that does not change the existing key names.

Thanks.