fluentsharp / FluentSharp

Fluent API for the .NET Framework (used by the O2 Platform)
63 stars 18 forks source link

Change sub-modules to be fetched using https instead of SSH #36

Closed romichg closed 8 years ago

romichg commented 9 years ago

Since submodules are public repositories, it is not necessary to require an overhead of ssh authentication for users wanting to fetch the whole FluentSharp repo. Kinda defeats the purpose of public:) Specifically change: [submodule "FluentSharp_Fork.CassiniDev"] path = FluentSharp_Fork.CassiniDev url = git@github.com:o2platform/FluentSharp_Fork.CassiniDev.git

To [submodule "FluentSharp_Fork.CassiniDev"] path = FluentSharp_Fork.CassiniDev url = https://github.com/o2platform/FluentSharp_Fork.CassiniDev.git

DinisCruz commented 9 years ago

For reference the reason those where done as git@github.com paths is due to the fact that I can push push from those sub-modules when doing local development

DinisCruz commented 9 years ago

Actually we can still use the git mode for public repos (like this one), see here https://github.com/TeamMentor/TM_4_0_QA/commit/aba9937f632c34ab93e0a6daaa9fa22512516d6f

basically we need to use

git:github.com/o2platform/FluentSharp_Fork.CassiniDev.git

This should work ok for both use cases:

romichg commented 9 years ago

not really. the git mode assumes SSH and looks for a key regardless if the repo is public.

DinisCruz commented 9 years ago

not if you use the format git//:github.com/o2platform/FluentSharp_Fork.CassiniDev.git

See this info on http://docs.travis-ci.com/user/build-configuration/

image

romichg commented 9 years ago

Hmm.. ok we have to try this with TC